-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add default_config verb to create a default configuration file #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried this out (rebased on top of main) and I do think it would be a helpful addition to this tool (everything worked as advertised)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ottojo thanks for the contribution and thank you @mikeferguson for reviewing this PR.
Left a couple of nitpicks to address before we can merge.
Alternatively @mikeferguson if you could open a PR with the main
rebase and the copyright headers added, happy to merge that in as long as the origin commit authored by @ottojo is preserved.
@@ -0,0 +1,16 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add copyright header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a header, not sure if it is expected to dedicate copyright to OSRF, that can be done if desired.
@@ -0,0 +1,31 @@ | |||
import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add copyright header.
d4dd78f
to
08c4fb3
Compare
Nice to see some activity here, I think package documentation is such an important aspect of ROS with much room for improvement! I rebased the commit to latest main, and tested it myself as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing this forward
Looks like our linters have flagged some formatting issues with the changes proposed. Do you mind addressing them? |
Signed-off-by: Jonas Otto <[email protected]>
08c4fb3
to
62f8e6e
Compare
should be fixed! @Yadunund |
Information about the config file format is hard to find, i think this makes it easier to use.
This adds a verb
default_config
which just writes the default config file already present in the code to a file, to be customized by the package author.