Show standard docs #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfoote
reviewed
Apr 13, 2024
There was a problem hiding this comment.
Overall this looks good. I squashed and merged #96 to get CI back to green for the moment. I hope to have a better solution soon. Can I reviewed the specific commits that look good. Can you rebase this, though it looks like the auto merge can handle the conflicts actually. And I had a question about README.md support.
rkent
force-pushed
the
show-standard-docs
branch
from
2de2673
to
2463aa5
Compare
tfoote
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we add a section to the home page that lists any of 5 standard documents that are found. It also includes the concept from PR #61 to include the README on the home page. If accepted, this would supersede that PR, but also should give credit here to @ottojo.
I needed tests to pass, so I chose the current tfoote-patch-1 branch to base this on. This PR will need rebasing after a solution is chosen to get tests working again.