Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GitHub Organizations #590

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

DLu
Copy link

@DLu DLu commented Sep 11, 2024

I tried to follow the link on the bottom of this page and hit a 404. I programmatically replaced the following strings:

  • ros-planning/navigation2 ➡️ ros-navigation/navigation2
  • ros-planning/docs ➡️ ros-navigation/docs

This follows the organizational changes mentioned here and here

Signed-off-by: David V. Lu <[email protected]>

.. _nav2_params file: https://github.com/ros-planning/navigation2/blob/main/nav2_bringup/bringup/params/nav2_params.yaml
.. _nav2_params file: https://github.com/ros-navigation/navigation2/blob/main/nav2_bringup/bringup/params/nav2_params.yaml

.. _documentation site: https://rosplanning.github.io/docs.nav2.org/
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if these need changes too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh - yes probably!

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tak (thank you in Danish - see you in Europe)!

docker build --tag navigation2:$ROS_DISTRO \
--build-arg FROM_IMAGE=ros:$ROS_DISTRO \
--build-arg OVERLAY_MIXINS="release ccache lld" \
--cache-from ghcr.io/ros-planning/navigation2:main \
--cache-from ghcr.io/ros-navigation/navigation2:main \
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only instance where it wasn't pointing at github.com

Copy link
Member

@SteveMacenski SteveMacenski Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a correct update - github spawns that for us for the package manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants