ros2 fixed camera_info service #291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariodenardi
changed the title
ahcorde
requested changes
Jan 10, 2024
There was a problem hiding this comment.
do you mind to fix linters https://build.ros2.org/job/Hpr__image_common__ubuntu_jammy_amd64/6/testReport/junit/(root)/projectroot/uncrustify/ ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use two stereo cameras. When I calibrated the cameras with the ROS calibrator, after clicking on commit, the tool wrote four files simultaneously:
cam_0.yamlandcam_1.yamlwith the parameters of the left camera, andcam_0.yamlandcam_1.yamlwith the parameters of the right camera. This caused me to lose the configuration of one camera.The issue arises from both cameras using the same service:
/camera_info. I resolved this problem by adding the camera's name in the constructor.