Update fisheye distortion model definition #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 23, 2020
Closed
|
+1 This is the correct thing to do. See my comment on common_msgs#151 for the full explanation. |
|
@DavidTorresOcana @mintar Is this PR dependent upon the others? It looks like it builds without it but we're talking about a text string that probably doesn't have a definition backing it until at least ros-perception/vision_opencv#306 is merged, right? |
|
@JWhitleyWork This PR does not depends on ros-perception/vision_opencv#306 nor ros-perception/vision_opencv#358 It simply renames the distortion model the tool gives to the distortion model already defined in ros/common_msgs so that they match. So those two need to be the same. See this PR comments |
|
Thanks for the clarification. LGTM! |
JWhitleyWork
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update fisheye distortion model definition.
Replaces #581 retargeting to
noeticUpdate calibration tool distortion model for fisheye camera to be compatible with ros-perception/vision_opencv#306 and ros-perception/image_common#146 in as indicated in ros/common_msgs#151.