Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed arguments when using the rclcpp_component as a regular node in image_view #825

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jun 30, 2023

Fixed arguments when using the rclcpp_component as a regular node in image_view

Related with this issue #824

I can also open PRs for the other nodes.

@mikeferguson
Copy link
Member

mikeferguson commented Jan 17, 2024

This seems very verbose - why can't we do:

auto args = rclcpp::init_and_remove_ros_arguments(argc, argv);
rclcpp::NodeOptions options;
options.arguments(args);

Which is what is generated if you use "rclcpp_components_register_node" (also why not just use that macro in the CMake?)

@mikeferguson
Copy link
Member

I also posted some comments in the original ticket - because I don't think this is actually needed - I think we just need to update documentation (somewhere) to reflect the changed way of sending parameters from the command line

Copy link
Member

@mikeferguson mikeferguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we want to merge this - as far as I can see, things are working as-is, as long as you follow the proper command line parameter specifications - and this doesn't appear to make any difference with the "remapping doesn't work when using compression" issue

@mikeferguson
Copy link
Member

I believe that #851 is the correct approach to fix the remap issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants