allow use as component or node #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
approved these changes
Jan 18, 2024
mikeferguson
added a commit
to mikeferguson/image_pipeline
that referenced
this pull request
Jan 18, 2024
This addresses ros-perception#823: * depth_image_proc was never implemented properly this way * image_proc might have once worked this way, but it appears upstream has changed over time and it was no longer doing the job. * stereo_image_proc is actually implemented correctly - I just added a comment With this PR: ``` $ ros2 pkg executables image_proc image_proc crop_decimate_node image_proc crop_non_zero_node image_proc debayer_node image_proc image_proc image_proc rectify_node image_proc resize_node ``` ``` $ ros2 pkg executables depth_image_proc depth_image_proc convert_metric_node depth_image_proc crop_foremost_node depth_image_proc disparity_node depth_image_proc point_cloud_xyz_node depth_image_proc point_cloud_xyz_radial_node depth_image_proc point_cloud_xyzi_node depth_image_proc point_cloud_xyzi_radial_node depth_image_proc point_cloud_xyzrgb_node depth_image_proc point_cloud_xyzrgb_radial_node depth_image_proc register_node ```
mikeferguson
added a commit
to mikeferguson/image_pipeline
that referenced
this pull request
Jan 18, 2024
This addresses ros-perception#823: * depth_image_proc was never implemented properly this way * image_proc might have once worked this way, but it appears upstream has changed over time and it was no longer doing the job. * stereo_image_proc is actually implemented correctly - I just added a comment With this PR: ``` $ ros2 pkg executables image_proc image_proc crop_decimate_node image_proc crop_non_zero_node image_proc debayer_node image_proc image_proc image_proc rectify_node image_proc resize_node ``` ``` $ ros2 pkg executables depth_image_proc depth_image_proc convert_metric_node depth_image_proc crop_foremost_node depth_image_proc disparity_node depth_image_proc point_cloud_xyz_node depth_image_proc point_cloud_xyz_radial_node depth_image_proc point_cloud_xyzi_node depth_image_proc point_cloud_xyzi_radial_node depth_image_proc point_cloud_xyzrgb_node depth_image_proc point_cloud_xyzrgb_radial_node depth_image_proc register_node ```
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #823:
With this PR: