Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling error for cv2.aruco.DICT from 6x6_50 to 7x7_1000 #961

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

VishalBalaji321
Copy link
Contributor

Hi,

There was mismatch of capitalisation of "X" for OpenCV cv2.aruco.DICT_nXn_ in camera_calibration package for dicts 6x6_50 to 7x7_1000

Previously:

"6x6_50"    : cv2.aruco.DICT_6x6_50,
"6x6_100"    : cv2.aruco.DICT_6x6_100,
"6x6_250"    : cv2.aruco.DICT_6x6_250,
...

After

"6x6_50"    : cv2.aruco.DICT_6X6_50,
"6x6_100"    : cv2.aruco.DICT_6X6_100,
"6x6_250"    : cv2.aruco.DICT_6X6_250,
...

This error came into notice when using charuco markers for calibration

Copy link
Member

@mikeferguson mikeferguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that cv2.aruco does in fact use uppercase X for all of these

@mikeferguson
Copy link
Member

CI appears to be broken after rolling to 24.04 migration - I don't see any formatting issues here, so merging

@mikeferguson mikeferguson merged commit 3f8c543 into ros-perception:rolling Mar 19, 2024
1 of 3 checks passed
Kotochleb pushed a commit to Kotochleb/image_pipeline that referenced this pull request May 27, 2024
…rception#961)

There was mismatch of capitalisation of "X" for OpenCV
cv2.aruco.DICT_n**X**n_ in camera_calibration package for dicts 6x6_50
to 7x7_1000

Co-authored-by: Vishal Balaji <[email protected]>
RBT22 pushed a commit to EnjoyRobotics/image_pipeline that referenced this pull request Jun 21, 2024
…rception#961)

There was mismatch of capitalisation of "X" for OpenCV
cv2.aruco.DICT_n**X**n_ in camera_calibration package for dicts 6x6_50
to 7x7_1000

Co-authored-by: Vishal Balaji <[email protected]>
mikeferguson pushed a commit that referenced this pull request Jun 21, 2024
…o 7x7_1000 (#961) (#1004)

Backport #961 fix to humble

Co-authored-by: Vishal Balaji <[email protected]>
Co-authored-by: Vishal Balaji <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants