Update for compatibility with image_geometry 4.1.0 #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2024
|
Thank you @ScottMonaghan for the contribution. CI is broken, we need to wait to have a |
|
@ros-pull-request-builder retest this please |
ahcorde
approved these changes
May 8, 2024
|
It appears this may not be complete? The latest dev job has a failed test: |
|
Hmm... that means we're referencing an image_geometry package older than the current 4.1 release: https://index.ros.org/p/image_geometry/github-ros-perception-vision_opencv/#rolling In 4.1 from_camera_info replaces FromCameraInfo which has been deprecated. |
|
Looks like Rolling has 4.1 - but Jazzy only has 4.0? Is that expected? |
|
Certainly not what I expected, but I'm new here and may have made a mistake. @ijnek, can you offer some insight here? image-geometry should be 4.1 for Jazzy correct? |
ScottMonaghan
changed the title
Kotochleb
pushed a commit
to Kotochleb/image_pipeline
that referenced
this pull request
May 27, 2024
This is a PR to fix: - ros-perception#966 As noted in ros-perception#966, as of writing image_pipeline [4.1.0 has been released](https://github.com/ros-perception/vision_opencv/releases/tag/4.1.0), is updated on [index.ros.org](https://index.ros.org/p/image_geometry/github-ros-perception-vision_opencv/#rolling), but it has not yet been migrated to [packages.ros.org](http://packages.ros.org/ros2/ubuntu/dists/noble/main/binary-amd64/Packages). As such `camera_calibration` will also require the source of [image_pipeline 4.1.0](https://github.com/ros-perception/vision_opencv/releases/tag/4.1.0) or higher to successfully build. I tested to ensure successful build with colcon build & colcon test. Note that colcon test has the following warning that is out of scope of this PR: ``` =============================== warnings summary =============================== src/camera_calibration/calibrator.py:47 Warning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives ``` Please let me know if there are any questions, concerns, or requested changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to fix:
As noted in #966, as of writing image_geometry 4.1.0 has been released, is updated on index.ros.org, but it has not yet been migrated to packages.ros.org.
As such
camera_calibrationwill also require the source of image_geometry 4.1.0 or higher to successfully build.I tested to ensure successful build with colcon build & colcon test.
Note that colcon test has the following warning that is out of scope of this PR:
Please let me know if there are any questions, concerns, or requested changes.