[rolling] image_publisher: Fix loading of the camera info parameters on startup #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kotochleb
changed the title
ahcorde
reviewed
May 27, 2024
Kotochleb
force-pushed
the
bugfix/image-publisher-camera-info-startup
branch
from
68e9e3a
to
1306e63
Compare
Kotochleb
force-pushed
the
bugfix/image-publisher-camera-info-startup
branch
from
1306e63
to
2d58d0e
Compare
Kotochleb
changed the title
|
@ahcorde the changes were retargeted to |
ahcorde
requested changes
May 27, 2024
| @@ -71,36 +71,46 @@ ImagePublisher::ImagePublisher( | |||
| auto param_change_callback = | |||
| [this](std::vector<rclcpp::Parameter> parameters) -> rcl_interfaces::msg::SetParametersResult | |||
| { | |||
| RCLCPP_INFO(get_logger(), "param_change_callback"); | |||
| @@ -224,9 +234,7 @@ void ImagePublisher::onInit() | |||
| camera_info_.p = {1, 0, static_cast<float>(camera_info_.width / 2), 0, 0, 1, | |||
| static_cast<float>(camera_info_.height / 2), 0, 0, 0, 1, 0}; | |||
|
|
|||
| timer_ = this->create_wall_timer( | |||
There was a problem hiding this comment.
if you remove these lines the dowork method will never be called and the image will be never flipped
There was a problem hiding this comment.
The timer is set in the reconfigureCallback. I didn't want to repeat the CameraInfoManager block of code in onInit and did not want to create timer there just to recreate it once again in reconfigureCallback.
ahcorde
approved these changes
May 29, 2024
|
https://github.com/Mergifyio backport jazzy humble iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 29, 2024
…on startup (#983) As described in #965 camera info is not loaded from the file on node initialization, but only when the parameter is reloaded. This PR resolves this issue and should be straightforward to port it to `Humble`, `Iron` and `Jazzy`. (cherry picked from commit 847920b) # Conflicts: # image_publisher/src/image_publisher.cpp
mergify bot
pushed a commit
that referenced
this pull request
May 29, 2024
…on startup (#983) As described in #965 camera info is not loaded from the file on node initialization, but only when the parameter is reloaded. This PR resolves this issue and should be straightforward to port it to `Humble`, `Iron` and `Jazzy`. (cherry picked from commit 847920b) # Conflicts: # image_publisher/src/image_publisher.cpp
mergify bot
pushed a commit
that referenced
this pull request
May 29, 2024
…on startup (#983) As described in #965 camera info is not loaded from the file on node initialization, but only when the parameter is reloaded. This PR resolves this issue and should be straightforward to port it to `Humble`, `Iron` and `Jazzy`. (cherry picked from commit 847920b) # Conflicts: # image_publisher/src/image_publisher.cpp
mikeferguson
added a commit
that referenced
this pull request
Jun 10, 2024
…n startup (backport #983) (#996) As described in #965 camera info is not loaded from the file on node initialization, but only when the parameter is reloaded. This PR resolves this issue and should be straightforward to port it to `Humble`, `Iron` and `Jazzy`.<hr>This is an automatic backport of pull request #983 done by [Mergify](https://mergify.com). --------- Co-authored-by: Krzysztof Wojciechowski <[email protected]> Co-authored-by: Michael Ferguson <[email protected]>
mikeferguson
added a commit
that referenced
this pull request
Jun 10, 2024
…startup (backport #983) (#997) As described in #965 camera info is not loaded from the file on node initialization, but only when the parameter is reloaded. This PR resolves this issue and should be straightforward to port it to `Humble`, `Iron` and `Jazzy`.<hr>This is an automatic backport of pull request #983 done by [Mergify](https://mergify.com). --------- Co-authored-by: Krzysztof Wojciechowski <[email protected]> Co-authored-by: Michael Ferguson <[email protected]>
mikeferguson
pushed a commit
that referenced
this pull request
Jun 10, 2024
… startup (backport #983) (#995) As described in #965 camera info is not loaded from the file on node initialization, but only when the parameter is reloaded. This PR resolves this issue and should be straightforward to port it to `Humble`, `Iron` and `Jazzy`.<hr>This is an automatic backport of pull request #983 done by [Mergify](https://mergify.com). Co-authored-by: Krzysztof Wojciechowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #965 camera info is not loaded from the file on node initialization, but only when the parameter is reloaded.
This PR resolves this issue and should be straightforward to port it to
Humble,IronandJazzy.