Allow users to override encoding string in ROSCvMatContainer #505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #504
The implementation here relies on using an
std::optional<std::string> encoding_override
argument which can be supplied during instantiation ofROSCVMatContainer
. If provided, the value will be used, else default to the existing behavior of inferring the encoding fromcv::Mat::type()
.In order to use
std::optional
, I also had to bump the C++ version to C++17.Also it looks like
ROSCvMatContainer::get_sensor_msgs_msg_image_copy()
has duplicate code fromconvert_to_ros_message()
. I've left a TODO to explore reusing the latter within this function. Happy to implement it if the change is acceptable.Signed-off-by: Yadunund [email protected]