Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use str in mapName function #51

Open
wants to merge 1 commit into
base: lunar-devel
Choose a base branch
from

Conversation

tylerlum
Copy link

@tylerlum tylerlum commented Feb 26, 2018

Issue: mapName function currently uses const char * as input and output. However, std::string is much easier to work with.

Solution: change mapName function parameter and return type changed from const char * -> std::string, as strings are easier to concatenate and work with in general.

@CodeFinder2
Copy link

You should also keep in mind that mapName() is called multiple times per simulation loop / iteration so using std::string may decrease performance here...especially using by-value calls (non-reference parameter and std::stringstream).

(Just my 2 cents... 🙈 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants