Prepending node namespace to relative topics and adding validation for topic names #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brawner
force-pushed
the
fixing_topic_names
branch
from
2a7c5cc to
70c6ae2
Compare
dirk-thomas
reviewed
Dec 13, 2018
mlautman
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously relative topic names were not properly handled. This remaps relative topic names to the namespace of rqt_gui's node, which is currently just '/'. It also adds in topic name and type name validation so users won't crash rqt_gui by entering bad topic names.
This addresses issue #5 and issue #3