Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGB, lux and color temperature #133

Open
aPonza opened this issue Oct 5, 2018 · 3 comments
Open

RGB, lux and color temperature #133

aPonza opened this issue Oct 5, 2018 · 3 comments

Comments

@aPonza
Copy link

aPonza commented Oct 5, 2018

I will be using sensor TCS34725 and from it's python library I can see it provides the user with:

  • RGB color data (0-255 values);
  • color temperature (in K);
  • illuminance (in lux).

The sensor only reads RGBC data, the last two are calculated values, so nothing I can't do on my own from a published RGB-type message. However, I have found that the only really officially supported message regarding color sensor data is the illuminance message, as there is an RGBA color message but it seems to be more geared towards a different kind of usage (because of the alpha).

I have previously worked a bit with colors and know about the multitude of standards that exist, so that might be a reason why this hasn't been implemented yet. Regardless, if we stay within the robotics applications, an RGB/sRGB definition could be enough, and would set a standard way to talk about RGB/sRGB colors.

Is this worth talking about as a standard or should I use my own message for my own use case?

@aPonza
Copy link
Author

aPonza commented Oct 5, 2018

It seems like #5 and this would have been related.

@tfoote
Copy link
Member

tfoote commented Oct 11, 2018

Yeah, there hasn't been many sensors providing single point RGB data so I don't think that there's been much demand for a standard message for it. In general we want to see a message being used successfully before accepting it into common_msgs. So I'd suggest that you prototype your own message and once it's working successfully you propose to add it back here for it to be reviewed.

Note that I'd suggest not trying to include the calculated values, only the raw sensor data. And maybe you could publish the Illuminance on a separate topic using the exisiting message in case other users want to use it.

@aPonza
Copy link
Author

aPonza commented Oct 11, 2018

Ok, sure, it makes sense! And I'm definitely agreeing on calculated values. I'll update this once the sensors arrive and I have something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants