Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support multiple activation and deactivation #13

Open
wants to merge 2 commits into
base: indigo-devel
Choose a base branch
from

Conversation

HannesSommer
Copy link

This supports linking multiple REGISTER_ROSCONSOLE_BRIDGE; together and therefore enables ROS libraries to take care of this for non-ROS libraries they might depend on without risk.

This is one possible first step to improve on issue #12 .

The extra complexity to support deactivation is not necessary.
Currently it is just used to allow the "cleanup" test to remain partial functional. Admittedly this way it does not serve as much of a purpose as before. The problem is the introduced singleton that takes care of disabling the output handler at program termination. I don't know an easy way to test this from within the program without extra complexity in the library itself. However, the standard guarantees the destruction of static locals within the program termination phase - as far as I know. And the deactivate functionality is still successfully tested:

[ WARN] [1501317381.498355918]: This warning should be served through rosconsole
Warning: This warning should be served through the original console_bridge output handler
at line 9 in .../rosconsole_bridge/test/cleanup.cpp

(its output on my system)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant