Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pull_request_template.md to include package name review template #39987

Closed
wants to merge 2 commits into from
Closed

Update pull_request_template.md to include package name review template #39987

wants to merge 2 commits into from

Conversation

ijnek
Copy link
Contributor

@ijnek ijnek commented Feb 21, 2024

Updates issue template

@ijnek
Copy link
Contributor Author

ijnek commented Feb 29, 2024

@nuclearsandwich fyi

audrow
audrow reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me. I'd like to get some other eyes on it before merging.

nuclearsandwich
nuclearsandwich requested changes Mar 19, 2024
View reviewed changes
Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the suggestion here! I brought this up in today's ROS core meeting and we're concerned with adding an additional tree to the "choose your own adventure" template. Do you think you could instead make the REP-144 requirement part of the DOC INDEX review, which already serves a similar purpose of registering a source repository to be indexed in rosdistro?

@sloretz sloretz added the changes requested Maintainers have asked for changes to the pull request label Mar 29, 2024
@ijnek ijnek mentioned this pull request Apr 9, 2024
Open
@ijnek
Copy link
Contributor Author

ijnek commented Apr 9, 2024

Thanks for the review @audrow and @nuclearsandwich , i have addressed your feedback in #40518. Closing this PR since it is superceded.

@ijnek ijnek closed this Apr 9, 2024
@ijnek ijnek deleted the patch-4 branch April 9, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audrow audrow audrow left review comments

@nuclearsandwich nuclearsandwich nuclearsandwich requested changes

Assignees
No one assigned
Labels
changes requested Maintainers have asked for changes to the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ijnek @nuclearsandwich @audrow @sloretz