Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix debian : vcstool package name #42102

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

mosfet80
Copy link
Contributor

@mosfet80 mosfet80 commented Jul 16, 2024

fix debian package name from python3-vcstool to vcstool

Package name:

python3-vcstool

Package Upstream Source:

vcstool for debian bullseye
python3-vcstool for other Debian distributions

Purpose of using this:

python3-vcstool not exist in debian bookworm - bullseye distro

Links to Distribution Packages

Please Add This Package to be indexed in the rosdistro.

ROSDISTRO NAME : ALL

The source is here:

https://packages.debian.org/bookworm/vcstool

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

@mosfet80 mosfet80 requested a review from a team as a code owner July 16, 2024 12:50
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Jul 16, 2024
@mosfet80 mosfet80 changed the title Patch 3 fix debian : vcstool package name Jul 16, 2024
@marcoag
Copy link
Contributor

marcoag commented Jul 16, 2024

Info is confusing:

python3-vcstools for debian bullseye
python3-vcstool for other Debian distributions

it also provides a link to bookworm but modifies bullseye.

@marcoag marcoag added the changes requested Maintainers have asked for changes to the pull request label Jul 16, 2024
Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CONTRIBUTING.md describes the expected package sources for each distribution. For Debian, the ROS package repositories are included in the list.

The python3-vcstool package is available for all current Debian releases in the ROS repositories. That package is what this rule refers to. Upstream debian later decided to package vcstool as well, and then in Bookworm decided to rename the package to vcstool. That's fine - they can do what they want - but this rule still refers to the package provided by the ROS repositories, as it always has.

If your system can't find the package, you need to add the ROS package source to the system.

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to put request changes on this for the moment to make sure we don't merge this without thinking it through fully.

The current rule is pointing to the ROS packaged version. It appears to have just been adopted upstream and we should make a migration plan for switching over to the upstream assuming we test it as functional for our purposes.

@nuclearsandwich @cottsay FYI (also we probably need to add a conflicts now for our version too)

Copy link

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale Issue/PR hasn't been active in a while and may be closed. label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request rosdep Issue/PR is for a rosdep key stale Issue/PR hasn't been active in a while and may be closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants