-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix debian : vcstool package name #42102
base: master
Are you sure you want to change the base?
Conversation
fix debian bullseye package name from python3-vcstool to python3-vcstools
fix package name
Info is confusing:
it also provides a link to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CONTRIBUTING.md describes the expected package sources for each distribution. For Debian, the ROS package repositories are included in the list.
The python3-vcstool
package is available for all current Debian releases in the ROS repositories. That package is what this rule refers to. Upstream debian later decided to package vcstool as well, and then in Bookworm decided to rename the package to vcstool
. That's fine - they can do what they want - but this rule still refers to the package provided by the ROS repositories, as it always has.
If your system can't find the package, you need to add the ROS package source to the system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to put request changes on this for the moment to make sure we don't merge this without thinking it through fully.
The current rule is pointing to the ROS packaged version. It appears to have just been adopted upstream and we should make a migration plan for switching over to the upstream assuming we test it as functional for our purposes.
@nuclearsandwich @cottsay FYI (also we probably need to add a conflicts now for our version too)
This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label. |
fix debian package name from python3-vcstool to vcstool
Package name:
python3-vcstool
Package Upstream Source:
vcstool for debian bullseye
python3-vcstool for other Debian distributions
Purpose of using this:
python3-vcstool not exist in debian bookworm - bullseye distro
Links to Distribution Packages
https://packages.debian.org/bookworm/vcstool
Please Add This Package to be indexed in the rosdistro.
ROSDISTRO NAME : ALL
The source is here:
https://packages.debian.org/bookworm/vcstool
Checks