Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated review action #42309

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Aug 2, 2024

This adds a preliminary automated reviewer for changes to this repository.

At present, only changes to rosdep are supported and there are probably a lot of rough edges, but it will still probably provide value as we continue to develop it and add additional checks.

It will be invoked when a PR is opened, but does not re-evaluate a PR until review is re-requested for github-actions[bot]. PR authors and rosdistro maintainers should both have the capability to re-request review.

(among the rough edges is documenting this behavior in the PR body)

@cottsay cottsay self-assigned this Aug 2, 2024
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still draft, but i believe this is really nice to support the review process with automated review comments.

I did not see the details of https://github.com/ros-infrastructure/rosdistro-reviewer, but do we already have the sample review result for the pull request?

Copy link

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale Issue/PR hasn't been active in a while and may be closed. label Aug 21, 2024
@cottsay cottsay added persistent Issue/PR won't be marked as stale if inactive for a while. and removed stale Issue/PR hasn't been active in a while and may be closed. labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
persistent Issue/PR won't be marked as stale if inactive for a while.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants