Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rosbag2_to_video to rolling index #42555

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bjsowa
Copy link
Contributor

@bjsowa bjsowa commented Aug 22, 2024

Please Add This Package to be indexed in the rosdistro.

rosbag2_to_video

The source is here:

https://github.com/fictionlab/rosbag2_to_video

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

@github-actions github-actions bot added the rolling Issue/PR is for the ROS 2 Rolling distribution label Aug 22, 2024
@clalancette
Copy link
Contributor

New package review checklist

I have two issues that prevent me from approving this:

  1. The version number is 0.0.0, which, while technically allowed, isn't great. I'd like to see that bumped to some number that isn't 0.
  2. We've only given the real upstream 2 weeks to respond to a request for release. I'll suggest we wait a bit longer before deciding to make the fork official.

@clalancette clalancette added the changes requested Maintainers have asked for changes to the pull request label Aug 26, 2024
@bjsowa
Copy link
Contributor Author

bjsowa commented Aug 29, 2024

  1. The version number is 0.0.0, which, while technically allowed, isn't great. I'd like to see that bumped to some number that isn't 0.

Fixed

  1. We've only given the real upstream 2 weeks to respond to a request for release. I'll suggest we wait a bit longer before deciding to make the fork official.

What would be the appropriate time to consider the fork official?

Copy link

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale Issue/PR hasn't been active in a while and may be closed. label Sep 13, 2024
@bjsowa
Copy link
Contributor Author

bjsowa commented Sep 13, 2024

bump

@github-actions github-actions bot removed the stale Issue/PR hasn't been active in a while and may be closed. label Sep 14, 2024
@bjsowa
Copy link
Contributor Author

bjsowa commented Sep 27, 2024

@clalancette Could you reconsider it now?

@bjsowa
Copy link
Contributor Author

bjsowa commented Oct 9, 2024

@clalancette friendly ping

@methylDragon
Copy link
Contributor

fyi @ivanpauno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request rolling Issue/PR is for the ROS 2 Rolling distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants