Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dh_python to rosdep/base.yaml #43178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frankkusters
Copy link
Contributor

Please add the following dependency to the rosdep database.

Package name:

dh_python

Package Upstream Source:

https://salsa.debian.org/python-team/tools/dh-python

Purpose of using this:

dh-python is used when a Debian package is created from a ROS package using the scripts generated by bloom.

Links to Distribution Packages

This package is only applicable to distributions which are Debian-based.

@frankkusters frankkusters requested a review from a team as a code owner October 14, 2024 15:18
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Oct 14, 2024
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not totally convinced that this is a good candidate for a rosdep key. As you say in your description, it is Debian-only, so it will never have equivalents on other platforms.

Could you explain a bit why you want to add it?

@frankkusters
Copy link
Contributor Author

I'm not totally convinced that this is a good candidate for a rosdep key. As you say in your description, it is Debian-only, so it will never have equivalents on other platforms.

Could you explain a bit why you want to add it?

We package pretty much everything as ROS packages in our project. It makes setting up a new developer machine incredibly easy with apt install (binary) or rosdep install (from source).

We also have packages for our build scripts, which depend on bloom and dh-python. Hence the need for us to have them as rosdep keys.

In a sense we're solving the same problem as the ros-dev-tools package 1:

I’ve always been annoyed with the long list of dependencies that had to be installed in order to develop ROS software. Spurred by @mikeferguson 's tweet I finally tried to do something about it.
[..]
ros-dev-tools has the following dependencies:
[..]
The new variants are now part of the standard installation path in the documentation.

With the added benefit that if dh-python is added as a rosdep key, we can fully use ROS infrastructure for our dependencies, keeping the number of tools to a minimum.

@clalancette
Copy link
Contributor

With the added benefit that if dh-python is added as a rosdep key, we can fully use ROS infrastructure for our dependencies, keeping the number of tools to a minimum.

Got it. Thanks for the explanation. I don't really have a strong objection, so I'll go ahead and approve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants