Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyveos_bridge and hyveos_msgs to rolling #44158

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

Zollerboy1
Copy link
Contributor

Please Add This Package to be indexed in the rosdistro.

Rolling

The source is here:

Checks

@github-actions github-actions bot added the rolling Issue/PR is for the ROS 2 Rolling distribution label Jan 13, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@christophebedard
Copy link
Member

christophebedard commented Jan 13, 2025

hyveoshyveos_bridge:

hyveos_msgs:

@tfoote
Copy link
Member

tfoote commented Jan 13, 2025

I wonder if the package should be called hyveos_bridge instead of just hyveos, since it's not HyveOS packaged for ROS

I think that this mostly comes down to do we ever expect that a ROS package would depend on hyveos or not. If it's possible that it could become a dependency (most likely a rosdep if this is bridging to it) we don't want to have a potential collision in the naming.

TBD depending on the package above, but I think it's probably fine

The messages relate to hyveos presumably so this should be fine. If it goes through a bridge or not is independent.

@Zollerboy1 Zollerboy1 changed the title Add hyveos and hyveos_msgs to rolling Add hyveos_bridge and hyveos_msgs to rolling Jan 13, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@Zollerboy1
Copy link
Contributor Author

@christophebedard @tfoote I agree and have already renamed the hyveos package to hyveos_bridge in https://github.com/p2p-industries/hyveos_ros. The hyveos_msgs package name is fine.

@christophebedard
Copy link
Member

Thank you both! Looks good to me now.

@christophebedard christophebedard merged commit c93e011 into ros:master Jan 13, 2025
5 checks passed
@Zollerboy1 Zollerboy1 deleted the rolling branch January 13, 2025 21:22
@Zollerboy1
Copy link
Contributor Author

Thanks! I'm getting a build error for hyveos_bridge from the ROS2 build farm, because apparently the rosdep key hyveos_msgs isn't available. Did I do anything wrong or will this sort out over time?

@christophebedard
Copy link
Member

christophebedard commented Jan 13, 2025

This is expected. It's trying to find the hyveos_msgs binary, but it doesn't exist yet.

You should first release the hyveos_msgs package/repo. Once that's done and the package is built, then you will be able to release hyveos_bridge and Rpr/Jpr/Rdev/Jdev jobs will work. Looks like the Rdev job (for example) uses the testing apt repository, so hyveos_msgs should only need to be released (bloom + PR here) and then built by the buildfarm. It won't need to be synced to the main apt repository, which can take some time.

If you don't intend to release your packages, then I think you'll have to put hyveos_msgs and hyveos_bridge in the same git repository for the Rdev/etc. jobs to work. In any case, having both packages in the same git repository would probably simplify the release process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rolling Issue/PR is for the ROS 2 Rolling distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants