install xacro using console_scripts entrypoint #304
Conversation
There was a problem hiding this comment.
Thanks. This looks more promising!
I was thinking about symlinking from lib/xacro to bin instead of installing the file a second time.
Symlinks are not supported in Windows.
... to ensure EXEC permissions
|
Looks like the new feature was only released into |
Ah i didnt notice this because I use rolling. Does this change need to wait until backports to non-eol distros are released then? |
Yes, I cannot release in this state. I also suggested some changes: ament/ament_cmake#328 (comment) |
|
I think the backport has been released. Could this PR be merged now? |
|
I think this is also blocked by ament/ament_cmake#372. Will double check... |
|
Closing and reopening to trigger CI. |
This was an attempt at making the ROS2 launch files work with the Python samples on Windows. The issue is that, if we simply try to launch the python script directly, we get the following error: ``` OSError: [WinError 193] %1 is not a valid Win32 application ``` In this commit, we try to make a Python module out of the samples, install them using `ament_cmake_python`, and use a `setup.cfg` to add a console script entry point. This way, we can launch the samples using both `ros2 run` and `ros2 launch` commands. This approach was modeled after: ros/xacro#304 This seemed to work. However, a new issue emerged. While `ros2 run` still works fine, now we are not getting any log output when launching it with `ros2 launch`. We seem to be encountering this issue: MISC-2024-06-19-ros2-testing
This changes xacro to be install using a console_script entrypoint, which now fixes running
xacroandros2 run xacro xacroin windows. linux functionality should be unchanged.closes #302
supersedes #303