reapply yuv encoding deprecation #257
Draft
+42
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Rauch <[email protected]>
Signed-off-by: Christian Rauch <[email protected]>
Signed-off-by: Christian Rauch <[email protected]>
Signed-off-by: Christian Rauch <[email protected]>
|
|
I'm going to be perfectly frank; I'm not sure that this is worth putting in. The simple fact is that these encodings are not standardized anywhere. And I am fine having two aliases for the same thing. Finally, this PR adds in a lot of That said, this is just my opinion, and I'm not going to fight hard for it. If others think that this is much clearer, then I'm not going to put up a fuss about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reapplies #247 with fixes for MSVC.
With ros2/rviz#1276 there are no references to the deprecated encodings
yuv422oryuv422_yuy2left in the core packages (https://github.com/ros2/ros2/blob/rolling/ros2.repos).Requires: