Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated security methods #77

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jan 24, 2025

These functions are not DDS specific, now that we have zenoh as an rmw we should move these functions to a more generic place.

I move to rmw_security_common, in sros2.

Related PR ros2/sros2#330

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde ahcorde self-assigned this Jan 24, 2025
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we decide where to move this functions, i think that is okay to deprecate those functions. those functions are not specific for DDS, but more like standard for pkcs#11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants