[service introspection] ros2 service echo #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 10, 2022
clalancette
force-pushed
the
service_introspection
branch
from
09a5c8c
to
465f571
Compare
|
I've reworked this to be a lot simpler now. It seems to now work fairly well; the only missing thing here is tests, which I'll do another time. |
|
@clalancette I've added a test checking that the tool can see all four types of events and content (c6fb6f3). It's not super thorough, but a good smoke test. |
clalancette
reviewed
May 15, 2023
There was a problem hiding this comment.
Thanks! This looks good to me now, so I'm going to go ahead with CI on it. I'd prefer another review (maybe from @jacobperron ) before merging, since I did substantial work here.
|
CI:
|
jacobperron
reviewed
May 16, 2023
clalancette
force-pushed
the
service_introspection
branch
from
c6fb6f3
to
936ea3c
Compare
Signed-off-by: deepanshu <[email protected]> Signed-off-by: Chris Lalancette <[email protected]>
Launch a test fixture with an introspectable client repeatedly sending requests to an introspectable service. The test checks that we can see all four expected service events sequentially using the new 'echo' verb. Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
clalancette
force-pushed
the
service_introspection
branch
from
7c15af1
to
ba9cedf
Compare
|
CI:
|
iuhilnehc-ynos
approved these changes
May 21, 2023
fujitatomoya
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for proposed REP2012 ros-infrastructure/rep#360
This PR implements
ros2 service echoRelated PR: ros2/ros2#1285
Depends on ros2/rclpy#1089