Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Batch upload engine #210

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Draft: Batch upload engine #210

wants to merge 8 commits into from

Conversation

LAShemilt
Copy link
Contributor

Solves #197

Use a decorator to change the way the that the exsiting files are added to the queue. If there are less than 2000 files in the directory the beaviour is maintained. If it is more then the decorator passes the files as batches to the queue. The batches are separated by a rest period determined by file weight.

This is to stop the file monitor crashing if too many files are added to the queue at once.

@LAShemilt LAShemilt requested a review from dfq16044 March 18, 2022 11:21
@LAShemilt LAShemilt self-assigned this Mar 18, 2022
Copy link
Contributor Author

@LAShemilt LAShemilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start needs work

@lgtm-com
Copy link

lgtm-com bot commented Apr 25, 2022

This pull request introduces 2 alerts when merging 853440d into ee12b87 - view on LGTM.com

new alerts:

  • 2 for Unused local variable

@LAShemilt
Copy link
Contributor Author

To Do:

  • Make sure this works with directory class
  • Make sure counter at the bottom of the file monitor represents the total number of files to be uploaded and not just the chunk size.

@LAShemilt LAShemilt force-pushed the batch-upload-engine branch from 853440d to 04ca8b3 Compare April 27, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant