-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Batch upload engine #210
Draft
LAShemilt
wants to merge
8
commits into
master
Choose a base branch
from
batch-upload-engine
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LAShemilt
commented
Mar 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start needs work
…corator more easily
…ager itself and refreshes when there are only 10% of the files to go
LAShemilt
removed request for
perdigao1,
dfq16044,
MasterVexillen and
elainehoml
April 25, 2022 08:00
This pull request introduces 2 alerts when merging 853440d into ee12b87 - view on LGTM.com new alerts:
|
To Do:
|
…es not change with the decorator
LAShemilt
force-pushed
the
batch-upload-engine
branch
from
April 27, 2022 08:27
853440d
to
04ca8b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #197
Use a decorator to change the way the that the exsiting files are added to the queue. If there are less than 2000 files in the directory the beaviour is maintained. If it is more then the decorator passes the files as batches to the queue. The batches are separated by a rest period determined by file weight.
This is to stop the file monitor crashing if too many files are added to the queue at once.