Fix a wrong LinkedIn url & UI Updates #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisTDR
changed the title
razvand
requested changes
Sep 7, 2024
There was a problem hiding this comment.
Hi, @DenisTDR , thanks for the fixes. Please update your commit messages, to feature the guidelines here (see The seven rules of a great Git commit message).
On the commit that improves the readability of the date and location (kudos for the nifty CSS tricks), please remove the | {{ .city }} part, as it's already part of POLITEHNICA Bucharest. See my suggestion in the review.
DenisTDR
force-pushed
the
main
branch
2 times, most recently
from
d456c63
to
d0bb9b7
Compare
DenisTDR
changed the title
razvand
requested changes
Sep 8, 2024
There was a problem hiding this comment.
Oh, yeah, something else.
Please use your name for commit authorship, i.e. replace TDR <[email protected]> with Denis Troncota <[email protected]> or equivalent.
And please also sign-off your commits.
Signed-off-by: Denis Troncota <[email protected]>
Signed-off-by: Denis Troncota <[email protected]>
Ignore IntelliJ IDEA output files. Signed-off-by: Denis Troncota <[email protected]>
Signed-off-by: Denis Troncota <[email protected]>
razvand
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.