-
Notifications
You must be signed in to change notification settings - Fork 75
Added pcl_ros-1.2.7 as a dummy artifact #52
base: indigo
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Hi @gb96, thanks for the report and the PR. I think the proper solution is to actually submit the messages to the repo. I would like to keep the PRs incremental, trying to address one issue at a time when possible; this changeset looks a bit big for me. I will add the missing artifacts when I have some time. If you want to submit a PR with only those artifacts, that would be great too. |
I'm sorry that I keep holding this PR, but I think I don't fully understand the problem. You say that you have a package that depends on In any case I don't mind adding dummy artifacts if that works for you, but I would prefer a PR with just that change (i.e. I would expect ~5 changed files, but not much more than that). |
Fixes #16 by contributing a "dummy" pcl_ros artifact
org/ros/rosjava_messages/pcl_ros
Sorry there are a bunch of other changes in the commit, so automatic merge will not be possible.
In case it helps, I have archived the added files and attached them to this PR.
org.ros.rosjava_messages.pcl_ros-127.zip