Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Added pcl_ros-1.2.7 as a dummy artifact #52

Open
wants to merge 6 commits into
base: indigo
Choose a base branch
from
Open

Added pcl_ros-1.2.7 as a dummy artifact #52

wants to merge 6 commits into from

Conversation

gb96
Copy link

@gb96 gb96 commented Mar 23, 2018

Fixes #16 by contributing a "dummy" pcl_ros artifact
org/ros/rosjava_messages/pcl_ros

Sorry there are a bunch of other changes in the commit, so automatic merge will not be possible.

In case it helps, I have archived the added files and attached them to this PR.
org.ros.rosjava_messages.pcl_ros-127.zip

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@jubeira
Copy link

jubeira commented Mar 23, 2018

Hi @gb96, thanks for the report and the PR.

I think the proper solution is to actually submit the messages to the repo. I would like to keep the PRs incremental, trying to address one issue at a time when possible; this changeset looks a bit big for me.

I will add the missing artifacts when I have some time. If you want to submit a PR with only those artifacts, that would be great too.

@gb96 gb96 closed this Mar 26, 2018
@gb96 gb96 reopened this Mar 26, 2018
@gb96
Copy link
Author

gb96 commented Mar 26, 2018

Reworked the PR with just the relevant pcl_ros artifact changes.
It is not possible to submit any messages because I don't think pcl_ros defines any new messages. They're all defined in pcl_msgs

@jubeira
Copy link

jubeira commented Mar 27, 2018

I'm sorry that I keep holding this PR, but I think I don't fully understand the problem.

You say that you have a package that depends on pcl_ros, not pcl_msgs, but you don't actually need the java implementation for pcl_ros (which does not exist). May I know which is the package that depends on pcl_ros and is implemented in Java? I mean, move_base, costmap_2d and so on are not Java packages, so I don't get how you got a Java package that depends on pcl_ros.

In any case I don't mind adding dummy artifacts if that works for you, but I would prefer a PR with just that change (i.e. I would expect ~5 changed files, but not much more than that).

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants