Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single moment range support and adjacent new ranges intersection interpretation #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

franjuan
Copy link

@franjuan franjuan commented Mar 2, 2017

Single moment range support and testing and adjacent ranges intersection new interpretation

  • Added a whole set of unit test for single moment ranges (start == end)
  • All former unit tests kept in order to assure former behaviour for all operations
  • New interpretation of intersect operation through option.adjacent:true parameter (same behaviour assured if no parameter or false value). In such case (adjacent: true), {---}[---] adjacent ranges, returns a single moment range at the union point, instead of null

Thank you

…ion new interpretation

* Added a whole set of unit test for single moment ranges (start == end)
* New interpretation of intersect operation through option.adjacent:true parameter (same behaviour assured if no parameter or false value). In such case, {---}[---] adjacent ranges, returns a single moment range at the union point
@Rhysjc
Copy link

Rhysjc commented Jul 26, 2017

Hey @franjuan, could you explain why we'd need single moment ranges? I can't see the advantage over just using a moment object.

@franjuan
Copy link
Author

Well, I would like to work indistinctly with ranges and moments, understandind that a Moment is a range of a single point

@gf3 gf3 added feature and removed enhancement labels Jan 19, 2018
@gf3 gf3 added the backlog label Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants