Skip to content

Commit

Permalink
PHP 8.1 minimum version prep
Browse files Browse the repository at this point in the history
  • Loading branch information
rotimi committed Mar 14, 2024
1 parent bbf62f2 commit 97e36d3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
8 changes: 2 additions & 6 deletions .github/workflows/php.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,13 @@ jobs:

strategy:
matrix:
php: [8.2, 8.1, 8.0, 7.4]
php: [8.3, 8.2, 8.1]
# prefer-lowest is causing unit tests to fail when php 7.2 is run against PHPunit 7.x,
# PHPUnit 8.x is the latest stable release that supports PHP 7.2 and that runs fine
# dependency-version: [prefer-lowest, prefer-stable]
dependency-version: [prefer-stable]
os: [ubuntu-20.04, ubuntu-22.04]
include:
- os: ubuntu-20.04
php: 7.4
- os: ubuntu-20.04
php: 8.0
- os: ubuntu-20.04
php: 8.1
- os: ubuntu-20.04
Expand All @@ -41,7 +37,7 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
4 changes: 1 addition & 3 deletions rector.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<?php
declare(strict_types=1);

use Rector\Set\ValueObject\SetList;
use Rector\Config\RectorConfig;
use Rector\TypeDeclaration\Rector\ClassMethod\AddVoidReturnTypeWhereNoReturnRector;

Expand All @@ -11,8 +10,7 @@
__DIR__ . '/src/smvc-tools/post-composer-create-project.php',
__DIR__ . '/src/controllers',
])
// uncomment to reach your current PHP version
->withPhpSets( php81: true )
->withPhpSets( php81: true ) // up to the php version here
->withRules([
//AddVoidReturnTypeWhereNoReturnRector::class,
])
Expand Down

0 comments on commit 97e36d3

Please sign in to comment.