Fix panics and unsafe code #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geigerzaehler
force-pushed
the
fix-panics-and-crashes
branch
from
6a0971b to
2181aa8
Compare
|
I think unsafe is used for performance reasons? The copy is unnecessary if unsafe can be shown to behave safely. |
|
@seanpianka, would you like to be a contributor to this repo, so that you can continue to work with the routerify project easily. |
|
@geigerzaehler, Could you please resolve the merge conflict and resend the PR? |
geigerzaehler
force-pushed
the
fix-panics-and-crashes
branch
from
2181aa8 to
4a749ba
Compare
|
I’ve updated the code and the description. |
|
@geigerzaehler Apologies for the trouble, but could you please resolve the conflicts so we can finally merge this? |
This change fixes panics (routerify#6) and unsafe code (routerify#5). This comes at the cost of an additional copy of the data send through the pipe and having a buffer in the state. All unsafe code is removed and the need for a custom `Drop` implementation which makes the code overall easier. We also provide an implementation for traits from `futures` which is behind a feature flag. We also add tests.
geigerzaehler
force-pushed
the
fix-panics-and-crashes
branch
from
4a749ba to
3949517
Compare
No problem. I’ve fixed the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes panics (#6) and unsafe code (#5). This comes at the cost of an additional copy of the data send through the pipe and having a buffer in the state. All unsafe code is removed and the need for a custom
Dropimplementation which makes the code overall easier.We also provide an implementation for traits from
futureswhich is behind a feature flag.We also add tests.