[pgadmin4] Be able to define existingSecret or existingConfigmap containing serverDefinitions #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erDefinitions Signed-off-by: Alex Hofmann <[email protected]>
rowanruseler
approved these changes
Apr 22, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[pgadmin4] Be able to define existingSecret or existingConfigmap containing serverDefinitions
What this PR does / why we need it:
When providing the pgadmin credentials via
.existingSecret, one is forced to also put server definitions in the exact same secret, if.serverDefinitions.resourceTypeis set to "Secret".This PR allows users to define a separate secret containing server definitions or to define an external ConfigMap
Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[pgadmin4])