Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overwrite existing key bindings #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jo-mueller
Copy link

Fixes #22

This PR adds an overwrite=True flag to the key binding. Since the key bindings are registered with the viewer, this error shows only upon closing/reopening the plugin.

@JoOkuma
Copy link
Member

JoOkuma commented Oct 23, 2023

Hi @jo-mueller, thanks a lot for the PR.

Once the tests pass, I'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when closing and re-opening the plugin
2 participants