add subset, offset and size index #146
Conversation
| import "errors" | ||
|
|
||
| type SubsetOffsetAndSize struct { | ||
| Subset uint64 // uint24, 3 bytes, max 16.7 MB (megabytes) |
There was a problem hiding this comment.
could be even smaller? uint16 ? but might not be worth it and better to have an extra byte
There was a problem hiding this comment.
Yeah I don't have a strong opinion here. @gagliardetto ?
There was a problem hiding this comment.
yeah uint16 should be eough
cmd-x-index-cid2subsetoffset.go
Outdated
| var network indexes.Network | ||
| var indexDir string | ||
| return &cli.Command{ | ||
| Name: "cid-to-offset", |
There was a problem hiding this comment.
this probably needs a different name
|
given that we have the metadata that states the byte beginning and end of split piece, we can avoid creating this new index and just use the existing there will be an extra step that will calculate the subset file from an offset. |
Do we have this @gagliardetto ? |
|
Ohhh you are saying we should add it -- #132 (comment) |
|
I suspect we are not going to need this after merging #132 Basically the existing indexes will "just work" |
No description provided.