Support .NET Core #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Adds support for .NET Core while maintaining support for mono. Tested on dotnet-2.2, dotnet-3, and mono 5.18.0.240 (latest on raspbian). Multichannel support should still work, though personally unable to test it.
In order for this fix to work, while still allowing for multichannel support, Settings.Channels[] changed to Settings.Channel_1 and Settings.Channel_2 where channelIndex=0 maps to Channel_1 and channelIndex=1 maps to Channel_2. As such, this changes the usage a little bit. I've created a gist here with a demo app showing the change. The TestApp solution is also updated to include this change.