Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl Send and Sync for Controller. #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/controller/controller.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,16 @@ pub struct Controller {
c_struct: ws2811_t,
}

/// It is safe to implement `Send` because `Controller` is the sole
/// owner of its internal `ws2811_t` object and the pointers it
/// contains, and those pointers are never exposed by this module's
/// API. Therefore, there is no risk of pointer aliasing.
unsafe impl Send for Controller {}

/// It is safe to implement `Sync` because the underlying `ws2811_t`
/// struct does not make use of any interior mutability.
unsafe impl Sync for Controller {}

impl Controller {
/// Creates a new Controller
///
Expand Down