Fix compile error on windows

[syokensyo]

PR Content Desc

• Compile on Windows will fail because of file capabilities feature introduced, even thought rpm is specific for Linux, but there are may be some cross platform tools build on top of this lib(such as my developing tools for rpm package info read and display)

📜 Checklist

• Commits are cleanly separated and have useful messages
• A changelog entry or entries has been added to CHANGELOG.md
• Documentation is thorough
• Test coverage is excellent and passes
• Works when tests are run --all-features enabled

[dralley]

@syokensyo Do you plan to undraft this?

[syokensyo]

@syokensyo Do you plan to undraft this?

There are some file conflicts, I'll resolve it first and then submit it again.

[dralley]

@syokensyo Could you rebase and squash the commits?

[dralley]

What do you think about simply disabling the validation on Windows rather than removing the whole feature?

edit: nvm, I suppose we couldn't do that without changing the representation from FileCaps to a String.

[syokensyo]

Yes, and capctl is platform specific, we also need some changes on it to make it work on Windows, I think that beyond the scope.

[dralley]

Ideally, the functionality for parsing capability info could be split off of the rest of the capctl crate, whether by feature or by splitting the actual crate, and then we could use that without pulling in the unix-specific bits. I'm not 100% certain but from a brief skim it looks possible. But, like you said, out of scope.

I'm thinking it is perhaps better to just store a string, and do validation via capctl on unix platforms where it is possible. I don't see a great reason to lock off the ability to set caps entirely.

[dralley]

I've filed cptpcrd/capctl#5 (comment)

[dralley]

No longer an issue