Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a minimal filecaps instead of capctl crate that can run on non-linux platform #201

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Use a minimal filecaps instead of capctl crate that can run on non-linux platform #201

merged 1 commit into from
Dec 5, 2023

Conversation

yybit
Copy link
Contributor

@yybit yybit commented Dec 5, 2023

Referring to capctl crate，implemented a simple filecaps that can validate caps text and run on non-linux platform.

📜 Checklist

  • Commits are cleanly separated and have useful messages
  • A changelog entry or entries has been added to CHANGELOG.md
  • Documentation is thorough
  • Test coverage is excellent and passes
  • Works when tests are run --all-features enabled

dralley
dralley approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@dralley dralley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work for now. I'd still like to see the capctl crate improve, I have a PR in progress there that I will try to finish eventually

@yybit
Copy link
Contributor Author

yybit commented Dec 5, 2023

Problems with rustfmt and tests occurred and I resubmitted the code.

@yybit yybit requested a review from dralley December 5, 2023 15:40
@dralley dralley merged commit e686c92 into rpm-rs:master Dec 5, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dralley dralley Awaiting requested review from dralley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yybit @dralley