Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixup. fix scriptlet string conversion impl #204

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fixup. fix scriptlet string conversion impl #204

merged 1 commit into from
Dec 12, 2023

Conversation

juliusl
Copy link
Contributor

@juliusl juliusl commented Dec 11, 2023

📜 Checklist

  • Commits are cleanly separated and have useful messages
  • A changelog entry or entries has been added to CHANGELOG.md
  • Documentation is thorough
  • Test coverage is excellent and passes
  • Works when tests are run --all-features enabled

@juliusl
Copy link
Contributor Author

juliusl commented Dec 11, 2023

@dralley When I was working on the cargo-generate-rpm pr I noticed the conversion impl I picked could be improved. Would it be okay to merge this?

@dralley dralley merged commit d5f17a1 into rpm-rs:master Dec 12, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dralley dralley dralley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliusl @dralley