-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation and add a few small features and fixes #210
Conversation
A scriptlet that runs at verification time
3668cf5
to
ecef365
Compare
const QFORMAT = 1 << 1; | ||
/// Critical for success/failure, | ||
/// | ||
/// Corresponds to RPMSCRIPT_FLAG_CRITICAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is no rpm spec, I find it helpful to have references to the C code names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really want super direct references to the RPM source code if it can be helped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits:
%foo
should always be code, generally more inline code blocks would allow to use i.e. tools likecargo-spellcheck
without too many false positives eventually- inconsistent
TODO
vs@todo
lines, we shouldn't have any but track them in issues
other than that,
LGTM 👍
I'm trying to split the irrelevant stuff out of my other PRs and get it merged a bit sooner, while I'm working out a few details on the more complex stuff. Making those PRs smaller is also nice.
The reason for all the little features is that the gaps were encountered in the process of writing new tests.
I went through some effort to make sure the commits are split cleanly as opposed to the other PRs where they got mashed up a bit.
📜 Checklist
--all-features
enabled