Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that reposync downloads duplicated NEVRA only once #1586

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Test that reposync downloads duplicated NEVRA only once #1586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c785416
Test that reposync downloads duplicated NEVRA only once
m-blaha Nov 4, 2024
bccc3da
Fix downloading multiple packages of the same NEVRA test
m-blaha Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions dnf-behave-tests/dnf/plugins-core/download-binary.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,12 @@ Scenario: Download an existing RPM when there are multiple packages of the same
And stdout contains "filesystem-3.9-2.fc29.x86_64.rpm"
And stdout contains "wget-1.19.5-5.fc29.x86_64.rpm"
# check that each file was being downloaded only once
And stdout does not contain "setup.*setup"
And stdout does not contain "filesystem.*filesystem"
And stdout does not contain "wget.*wget"
# By default re.search() (used by "stdout does not contain") does not match
# across multiple lines. To bypass this limitation and check that the package
# name is not present on multiple lines, use "(.|\n)*" pattern instead of ".*".
And stdout does not contain "setup(.|\n)*setup"
And stdout does not contain "filesystem(.|\n)*filesystem"
And stdout does not contain "wget(.|\n)*wget"
# check that the files have been downloaded
And file "/tmp/download/setup-2.12.1-1.fc29.noarch.rpm" exists
And file "/tmp/download/filesystem-3.9-2.fc29.x86_64.rpm" exists
Expand Down
17 changes: 17 additions & 0 deletions dnf-behave-tests/dnf/plugins-core/reposync.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,3 +394,20 @@ Scenario: Reposync does not stop downloading packages on the first error
And file "//{context.dnf.tempdir}/simple-base/x86_64/dedalo-signed-1.0-1.fc29.x86_64.rpm" exists
And file "//{context.dnf.tempdir}/simple-base/x86_64/labirinto-1.0-1.fc29.x86_64.rpm" exists
And file "//{context.dnf.tempdir}/simple-base/x86_64/vagare-1.0-1.fc29.x86_64.rpm" exists

# https://issues.redhat.com/browse/RHEL-64320
Scenario: Reposync doesn't download duplicit nevra multiple times
# create a repository containing a duplicated NEVRA
Given I copy repository "simple-base" for modification
And I execute "createrepo_c -n x86_64/labirinto-1.0-1.fc29.x86_64.rpm -n x86_64/labirinto-1.0-1.fc29.x86_64.rpm --duplicated-nevra=keep {context.dnf.tempdir}/repos/simple-base/"
And I use repository "simple-base"
When I execute dnf with args "reposync --download-path={context.dnf.tempdir}"
Then the exit code is 0
# check that the package have been downloaded
And file "//{context.dnf.tempdir}/simple-base/x86_64/labirinto-1.0-1.fc29.x86_64.rpm" exists
# check that the package was being downloaded only once
And stdout contains "labirinto-1.0-1.fc29.x86_64.rpm"
# By default re.search() (used by "stdout does not contain") does not match
# across multiple lines. To bypass this limitation and check that the package
# name is not present on multiple lines, use "(.|\n)*" pattern instead of ".*".
And stdout does not contain "labirinto-1\.0-1\.fc29\.x86_64\.rpm(.|\n)*labirinto-1\.0-1\.fc29\.x86_64\.rpm"
Loading