needs-restarting: get systemd boot time from UnitsLoadStartTimestamp #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inknos
force-pushed
the
needs-restarting-units-load-start-time
branch
from
1ed1009 to
eac7a3d
Compare
xsuchy
reviewed
Mar 13, 2024
evan-goode
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Looks good, thanks! Related: rpm-software-management/dnf5#1198
|
thanks for the review. apparently there is a failing test that need to pass before merging |
inknos
force-pushed
the
needs-restarting-units-load-start-time
branch
from
eac7a3d to
bfcd1d2
Compare
I am changing the logged message to debug level since it could be quite annoying and I don't want to change the output of the plugin |
jan-kolarik
approved these changes
Mar 18, 2024
evan-goode
added a commit
to evan-goode/dnf-plugins-core
that referenced
this pull request
Oct 3, 2024
Resolves https://issues.redhat.com/browse/RHEL-35577. Get the boot time from UnitsLoadStartTimestamp if systemd is available, but make sure to use the kernel boot time for calculating process start times using data from procfs. The previous attempt [1] at this failed to do so and introduced a regression [2]. Also, get the kernel boot time from the btime field of /proc/stat instead of calculating it from /proc/uptime, to be consistent with what procps-ng does. [1] rpm-software-management#527 [2] https://issues.redhat.com/browse/RHEL-39775
evan-goode
added a commit
to evan-goode/dnf-plugins-core
that referenced
this pull request
Oct 7, 2024
Resolves https://issues.redhat.com/browse/RHEL-35577. Get the boot time from UnitsLoadStartTimestamp if systemd is available, but make sure to use the kernel boot time for calculating process start times using data from procfs. The previous attempt [1] at this failed to do so and introduced a regression [2]. Also, get the kernel boot time from the btime field of /proc/stat instead of calculating it from /proc/uptime, to be consistent with what procps-ng does. [1] rpm-software-management#527 [2] https://issues.redhat.com/browse/RHEL-39775
evan-goode
added a commit
to evan-goode/dnf-plugins-core
that referenced
this pull request
Oct 7, 2024
Resolves https://issues.redhat.com/browse/RHEL-35577. Get the boot time from UnitsLoadStartTimestamp if systemd is available, but make sure to use the kernel boot time for calculating process start times using data from procfs. The previous attempt [1] at this failed to do so and introduced a regression [2]. Also, get the kernel boot time from the btime field of /proc/stat instead of calculating it from /proc/uptime, to be consistent with what procps-ng does. [1] rpm-software-management#527 [2] https://issues.redhat.com/browse/RHEL-39775
evan-goode
added a commit
to evan-goode/dnf-plugins-core
that referenced
this pull request
Oct 7, 2024
Resolves https://issues.redhat.com/browse/RHEL-35577. Get the boot time from UnitsLoadStartTimestamp if systemd is available, but make sure to use the kernel boot time for calculating process start times using data from procfs. The previous attempt [1] at this failed to do so and introduced a regression [2]. Also, get the kernel boot time from the btime field of /proc/stat instead of calculating it from /proc/uptime, to be consistent with what procps-ng does. [1] rpm-software-management#527 [2] https://issues.redhat.com/browse/RHEL-39775
evan-goode
added a commit
to evan-goode/dnf-plugins-core
that referenced
this pull request
Oct 11, 2024
Resolves https://issues.redhat.com/browse/RHEL-35577. Get the boot time from UnitsLoadStartTimestamp if systemd is available, but make sure to use the kernel boot time for calculating process start times using data from procfs. The previous attempt [1] at this failed to do so and introduced a regression [2]. Also, get the kernel boot time from the btime field of /proc/stat instead of calculating it from /proc/uptime, to be consistent with what procps-ng does. [1] rpm-software-management#527 [2] https://issues.redhat.com/browse/RHEL-39775
evan-goode
added a commit
to evan-goode/dnf-plugins-core
that referenced
this pull request
Oct 11, 2024
Resolves https://issues.redhat.com/browse/RHEL-35577. Get the boot time from UnitsLoadStartTimestamp if systemd is available, but make sure to use the kernel boot time for calculating process start times using data from procfs. The previous attempt [1] at this failed to do so and introduced a regression [2]. Also, get the kernel boot time from the btime field of /proc/stat instead of calculating it from /proc/uptime, to be consistent with what procps-ng does. [1] rpm-software-management#527 [2] https://issues.redhat.com/browse/RHEL-39775
ppisar
pushed a commit
that referenced
this pull request
Oct 14, 2024
Resolves https://issues.redhat.com/browse/RHEL-35577. Get the boot time from UnitsLoadStartTimestamp if systemd is available, but make sure to use the kernel boot time for calculating process start times using data from procfs. The previous attempt [1] at this failed to do so and introduced a regression [2]. Also, get the kernel boot time from the btime field of /proc/stat instead of calculating it from /proc/uptime, to be consistent with what procps-ng does. [1] #527 [2] https://issues.redhat.com/browse/RHEL-39775
evan-goode
added a commit
to evan-goode/dnf-plugins-core
that referenced
this pull request
Nov 19, 2024
Resolves https://issues.redhat.com/browse/RHEL-35577. Get the boot time from UnitsLoadStartTimestamp if systemd is available, but make sure to use the kernel boot time for calculating process start times using data from procfs. The previous attempt [1] at this failed to do so and introduced a regression [2]. Also, get the kernel boot time from the btime field of /proc/stat instead of calculating it from /proc/uptime, to be consistent with what procps-ng does. [1] rpm-software-management#527 [2] https://issues.redhat.com/browse/RHEL-39775
kontura
pushed a commit
that referenced
this pull request
Nov 21, 2024
Resolves https://issues.redhat.com/browse/RHEL-35577. Get the boot time from UnitsLoadStartTimestamp if systemd is available, but make sure to use the kernel boot time for calculating process start times using data from procfs. The previous attempt [1] at this failed to do so and introduced a regression [2]. Also, get the kernel boot time from the btime field of /proc/stat instead of calculating it from /proc/uptime, to be consistent with what procps-ng does. [1] #527 [2] https://issues.redhat.com/browse/RHEL-39775
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.