Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rhel-9.5: revert systemd boot time #537

Conversation

ppisar
Copy link
Contributor

@ppisar ppisar commented Jun 6, 2024

This revers rhel-9.5 commits:

486e9d4
a0ac871
74de8fe
Resolves: https://issues.redhat.com/browse/RHEL-39775

because it causes a regression.

@evan-goode, could you review this revert?

@evan-goode
Copy link
Member

I would prefer to keep in the documentation changes (commits "Needs-restarting: punctuation edits" and "Document needs-restarting boot time") but with the systemd method removed:

.. note::
   Needs-restarting will try to guess the boot time using two different methods:

   ``st_mtime of /proc/1``
        Reflects the time the first process was run after booting.
        This works for all known cases except machines without
        a RTC—they awake at the start of the epoch.
   ``/proc/uptime``
        Seconds field of ``/proc/uptime`` subtracted from the current time.
        Works for machines without RTC if the current time is reasonably correct.
        Does not work on containers which share their kernel with the
        host—there, the host kernel uptime is returned.


.. warning::
    Some systems are configured to read the RTC time in the local time
    zone. This mode cannot be fully supported. It will create various problems
    with time zone changes and daylight saving time adjustments. The RTC time
    is never updated, it relies on external facilities to maintain it. **If at
    all possible, use RTC in UTC by calling** ``timedatectl set-local-rtc 0``.
    See ``man timedatectl`` for more information.

The warning about RTC-in-local-TZ is good to have in there.

@ppisar
Copy link
Contributor Author

ppisar commented Jun 6, 2024

I did a partial revert like that in rhel-10. I can post it in a separate pull request for master branch if you want it in master.

But this full revert is for RHEL-9.5. We cannot just enhance the documentation because that would not fulfill approved acceptance criteria.

@ppisar ppisar changed the title Rhel 9.5 revert systemd boot time rhel-9.5: revert systemd boot time Jun 6, 2024
@evan-goode
Copy link
Member

I did a partial revert like that in rhel-10. I can post it in a separate pull request for master branch if you want it in master.

That would be great, thanks.

But this full revert is for RHEL-9.5. We cannot just enhance the documentation because that would not fulfill approved acceptance criteria.

Understood.

@ppisar ppisar merged commit ff993ed into rpm-software-management:rhel-9.5 Jun 6, 2024
1 of 3 checks passed
@ppisar
Copy link
Contributor Author

ppisar commented Jun 6, 2024

I did a partial revert like that in rhel-10. I can post it in a separate pull request for master branch if you want it in master.

That would be great, thanks.

#538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants