bootc: Implement the 'install' subcommand #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-goode
requested changes
Oct 1, 2024
evan-goode
reviewed
Oct 1, 2024
|
Looks like we're missing the PKGSPEC args: |
|
Addressed these findings and pushed an updated version of the patch. |
evan-goode
requested changes
Oct 7, 2024
|
Nice, should be good to go after merge conflicts are resolved and |
Useful for testing. The dnf-plugins-core RPM installs Python modules to /usr/lib/python3.XX/site-packages whereas a `make install` will by default install files to /usr/local/lib/python3.XX/site-packages.
For consumers of `dnf4 needs-restarting`'s output, it's useful to separate the systemd services needing restart vs. the processes not managed by systemd that need restarting. This new `dnf4 needs-restarting --exclude-services` ONLY prints information about processes NOT managed by systemd, and for listing systemd services that need to be restarted, the existing `--services` flag can be used. When both `--services` and `--exclude-services` are passed `--exclude-services` is ignored. For https://issues.redhat.com/browse/RHEL-56137.
Implement the 'install' subcommand for the bootc plugin and add documentation. Most of the options for this subcommand will come from global dnf command line option settings. The only option not handled is --os=OSNAME from rpm-ostree. https://issues.redhat.com/browse/SWM-3090
|
Thanks for the second review. I think I have everything taken care of now. |
evan-goode
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the 'install' subcommand for the bootc plugin and add documentation. Most of the options for this subcommand will come from global dnf command line option settings. The only option not handled is --os=OSNAME from rpm-ostree.
https://issues.redhat.com/browse/SWM-3090