cli: Progress bars miss newlines on non-interactive output

Resolves: #1058
rpm-software-management · Dec 8, 2023 · 8cb022d · 8cb022d
1 parent 8091c79
commit 8cb022d
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/libdnf5-cli/progressbar/multi_progress_bar.cpp b/libdnf5-cli/progressbar/multi_progress_bar.cpp
@@ -98,16 +98,14 @@ std::size_t MultiProgressBar::get_total_num_of_bars() const noexcept {
 std::ostream & operator<<(std::ostream & stream, MultiProgressBar & mbar) {
     const bool is_interactive{tty::is_interactive()};
 
-    if (is_interactive) {
-        if (mbar.num_of_lines_to_clear > 0) {
-            stream << tty::clear_line;
-            for (std::size_t i = 1; i < mbar.num_of_lines_to_clear; i++) {
-                stream << tty::cursor_up << tty::clear_line;
-            }
-            stream << "\r";
-        } else if (mbar.line_printed) {
-            stream << std::endl;
+    if (is_interactive && mbar.num_of_lines_to_clear > 0) {
+        stream << tty::clear_line;
+        for (std::size_t i = 1; i < mbar.num_of_lines_to_clear; i++) {
+            stream << tty::cursor_up << tty::clear_line;
         }
+        stream << "\r";
+    } else if (mbar.line_printed) {
+        stream << std::endl;
     }
     mbar.num_of_lines_to_clear = 0;
     mbar.line_printed = false;