Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the minimally support sequoia-openpgp version. #71

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

nwalfield
Copy link
Collaborator

  • Bump the minimally support sequoia-openpgp version to 1.21.1.

  - Bump the minimally support sequoia-openpgp version to 1.21.1.
Copy link

github-actions bot commented Jul 8, 2024

* 7d1748f957320ad07307ae805e6ed0b5ad045d55 Bump the minimally support sequoia-openpgp version.
|   - Authorized by Neal H. Walfield <[email protected]> [74E445BA0E15C957]
* 739a606da6ea1e836a415a1fd7899f36b7fd5a38 Release 1.6.0.
    - Trust root.

The pull request's base (739a606) authenticates the pull request's head (7d1748f).

@nwalfield
Copy link
Collaborator Author

@pmatilai, @dmnks: Can you please confirm that this failure is benign

  --- -	2024-07-08 20:25:03.887142823 +0000
  +++ /home/runner/work/rpm-sequoia/rpm-sequoia/rpm-build/tests/rpmtests.dir/at-groups/273/stdout	2024-07-08 20:25:03.882178157 +0000
  @@ -1,8 +1,8 @@
  -SHA256HEADER: eb512d3d8c282d0249701032591c53ffb5904c54c95de04783028387b224d8fe
  -SHA1HEADER: a42c611d67870c1937623f0da2631eabdf33e948
  -SIGMD5: 88d1037686ed3f5f6b67618b02cc47ef
  -PAYLOADDIGEST: 116ce41ebb72f1877cda3d7dedaf5b78770e202d6389ade4e415d78548d703a8
  -PAYLOADDIGESTALT: 116ce41ebb72f1877cda3d7dedaf5b78770e202d6389ade4e415d78548d703a8
  +SHA256HEADER: 94d13620f7058c14f24605c1461a9ef89b5b50b80c421a0a0eb7f0c62fe0f638
  +SHA1HEADER: 8036a9b66aa7781e4000a441e695bb076acfc450
  +SIGMD5: 98d3343d19052974392ed389e121f4f8
  +PAYLOADDIGEST: 91438332ac8fe92e4d4fcd45edb64b659323b893d9496a339f8587d19d00531a
  +PAYLOADDIGESTALT: 91438332ac8fe92e4d4fcd45edb64b659323b893d9496a339f8587d19d00531a
   /build/RPMS/noarch/attrtest-1.0-1.noarch.rpm:
       Header SHA256 digest: OK
       Header SHA1 digest: OK
  273. rpmsigdig.at:157: 273. rpmkeys -Kv <unsigned> 2 (rpmsigdig.at:157): FAILED (rpmsigdig.at:159)

@dmnks
Copy link

dmnks commented Jul 8, 2024

This looks a lot like (unfixed?) rpm-software-management/rpm#2874. Is this with rpm's master branch?

@dmnks
Copy link

dmnks commented Jul 8, 2024

Either way, this is probably some distro specifics leaking into the binary packages when they're built. We hardcode these hashes in the test suite and they're generated on Fedora. So this is most likely benign, indeed.

@nwalfield
Copy link
Collaborator Author

This looks a lot like (unfixed?) rpm-software-management/rpm#2874. Is this with rpm's master branch?

Ha, I forgot about that issue. This looks like the same benign failure (different check sums on a different OS).

To answer your question: no we decided to not upgrade rpm-sequoia's CI, but leave it at 4.18 on Ubuntu for now.

@nwalfield
Copy link
Collaborator Author

/fast-forward

@github-actions github-actions bot merged commit 7d1748f into main Jul 8, 2024
5 of 6 checks passed
@dmnks
Copy link

dmnks commented Jul 8, 2024

Ack, thanks. Looking at 4.18.2, it does include the commit that was supposed to fix this (rpm-software-management/rpm@7ec148c) so apparently it wasn't the complete fix then. That would also explain why the ticket is still open, too 😄

@nwalfield nwalfield deleted the neal/bump-sequoia-openpgp branch July 8, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants