-
Notifications
You must be signed in to change notification settings - Fork 359
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Replace per-file libmagic strings with MIME types in v6 packages
libmagic strings are useful for humans but less so for computers, in particular when you start having things like PNG image data, 16 x 16, 8-bit/color RGBA, non-interlaced All very fascinating but that level of image detail does not need to be in package metadata. The libmagic strings also make the exact output quite dependent on the exact libmagic version. They obviously want to improve their output but for rpm's purposes, this is unwanted instability. MIME types are far more predictable and also machine processable in a whole different level, and that is what we'll use for v6 packages. We need to still produce fully compatible v4 packages though, and there are external tools that look at the file class data in that tag, so we can't just reuse the tag for MIME in v6 either. Which means we need to duplicate all this goo, annoyingly. We get to drop some of it in v7, one day... Besides the concrete dictionary + per-file index header tags, add a header extension to fill in gaps of data where possible and build into a consumable format and add --filemime query alias for it, all very very similar to --fileclass. Add/adjust tests to match and show the difference between v4 and v6: v4 packages have fileclass but only extension-populated mime types, and v6 is the exact opposite. Fixes: #1096
- Loading branch information
Showing
12 changed files
with
216 additions
and
55 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.