-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't let macro '%-x' add extra space between flag and argument #2455
Conversation
490824b
to
3555d4b
Compare
This pull request required several push forces because the master branch of rpm on openSUSE 15.4 could not be built due to the missing package |
FWIW, you can build without rpm-sequoia by supplying |
We have no idea how many macros and packages out there are relying on the current, very long standing behavior. This may fix a use-case for you but is likely to break it for several others. |
Thanks for this pointer, which I can confirm that it works To run the generated
|
On openSUSE Leap 15.4 I found the following locations where such a flag is used:
|
A number of conditions are required for this to cause a problem:
In the following examples from the list given:
This post already contains a workaround for the mentioned problem, as
This occurrence is also a workaround for the problem mentioned, since
According to https://linux.die.net/man/1/quilt the format is
Only the value of |
… '-x <arg>'. Flags are added to this macro with the flag and argument in the original notation and separated from previous by spaces. Fix rpm-software-management#546
a23d8be
to
d05de19
Compare
As per the ticket conclusion, sorry but NAK: #2454 Apologies for taking so long with this. |
Fixes #2454, depends on #2449 (the commits from #2449 are included to avoid breaking CI)