Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add initial GitHub Actions configuration #2588

Closed
wants to merge 2 commits into from
Closed

CI: Add initial GitHub Actions configuration #2588

wants to merge 2 commits into from

Conversation

Conan-Kudo
Copy link
Member

Fixes #2569

@Conan-Kudo
tests: Do not use interactive mode for mktree.podman "make check"
2074852 
This causes execution to choke in CI environments like GitHub Actions
that do not provide a tty with errors like the following:

    sudo ./mktree.docker check
    shell: /usr/bin/bash -e {0}
  the input device is not a TTY
  Error: Process completed with exit code 1.

We want to avoid this and actually have the CI run properly.
@Conan-Kudo
CI: Add initial GitHub Actions configuration
5467e43
@Conan-Kudo
Copy link
Member Author

This will also lay the groundwork for us to add macOS CI to RPM, as GitHub Actions offers Mac runners we can use.

@dmnks dmnks mentioned this pull request Aug 3, 2023
Merged
@dmnks
Copy link
Contributor

dmnks commented Aug 3, 2023 •
edited
Loading

Thanks! Turns out to be easier than I thought 😄

As for the -i mode, we still want that, ideally as the default, since the script has to also work when run interactively on the developer's workstation, either through make check when there's no "native" backend available (currently anything other than Fedora Linux) or through make ci which is always present if Podman or Docker is installed. And -i is needed in order for the user to be able to interrupt the test-suite with CTRL-C.

So I took the liberty and adapted your PR so that --interactive=false can be passed as a parameter to mktree.podman check, and also added -j$(nproc) to the command in the workflow file so that the tests are run in parallel.

Closing this one in lieu of #2598.

@dmnks dmnks closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate away from SemaphoreCI Classic
2 participants
@Conan-Kudo @dmnks