Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter Lua deprecation warnings based on the originating rpm version #3270

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Filter Lua deprecation warnings based on the originating rpm version #3270

merged 2 commits into from
Sep 23, 2024

Commits on Sep 23, 2024

  1. Refactor scriptlet runner functions to take an actual rpmscript struct 

    These fellas have enough arguments as it is, it's moderately hysterical
they don't actually accept the main struct as an argument. No functional
changes.
    @pmatilai
    pmatilai committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f11cc51 View commit details
    Browse the repository at this point in the history

  2. Filter Lua deprecation warnings based on the originating rpm version 

    Issuing deprecation warnings on packages built long time ago is
just antisocial behavior when the user is powerless to do anything
about it.

When running scripts, pass the builder rpm version to Lua through the
registry, and filter out the warnings when the package was built with
an rpm version where these functions were not yet deprecated.
Usage through rpmlua and macros always gets warnings: those are things
that can technically be fixed by the user.
    @pmatilai
    pmatilai committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    56ebcd0 View commit details
    Browse the repository at this point in the history